| commit | c0602363eaf2a010d2657aadf12dac03cdc7b56e | [log] [tgz] |
|---|---|---|
| author | Jungshik Shin <[email protected]> | Tue Jun 25 16:22:17 2013 -0700 |
| committer | ChromeBot <[email protected]> | Wed Jun 26 17:44:45 2013 -0700 |
| tree | 9ac0321f6dff15e359e28c18bdeb3101a8c3c112 | |
| parent | aa18e1641879f2df5993c2b02eb6f50d4443a649 [diff] |
Replace deprecated g_thread_create with g_thread_try_new g_thread_create was deprecated in glib 2.32 (the current glib we use) and we need to update glib to 2.34.x to fix complex script shaping bugs in Chrome's UI area ( http://crbug.com/245783 ) The CL to update glib 2.34.x is at https://gerrit.chromium.org/gerrit/#/c/59652/ BUG=chromium:254228 TEST=1. Build and run unit tests 2. Run trybot builds on x86, amd64 and arm Change-Id: Ia6f58f7d18d6963fe3236bd56e819e38253a7fc8 Reviewed-on: https://gerrit.chromium.org/gerrit/60001 Reviewed-by: Chris Sosa <[email protected]> Commit-Queue: Jungshik Shin (jungshik at google) <[email protected]> Tested-by: Jungshik Shin (jungshik at google) <[email protected]>
diff --git a/full_update_generator.cc b/full_update_generator.cc index 311cc28..4e7e0e4 100644 --- a/full_update_generator.cc +++ b/full_update_generator.cc
@@ -70,7 +70,9 @@ }; bool ChunkProcessor::Start() { - thread_ = g_thread_create(ReadAndCompressThread, this, TRUE, NULL); + // g_thread_create is deprecated since glib 2.32. Use + // g_thread_new instead. + thread_ = g_thread_try_new("chunk_proc", ReadAndCompressThread, this, NULL); TEST_AND_RETURN_FALSE(thread_ != NULL); return true; }