update_engine: clean up depreacated values in omaha response There are a few depreacated values that still exist only in the unittests which needs complete depreacation: These are include: - needsadmin - ChromeOSVersion - IsDelta Also replace sample_omaha_v3_response.xml with a newer sample. BUG=none TEST=unittests pass Change-Id: If22e08dd350faf700898af9a86876628ed00f1a5 Reviewed-on: https://chromium-review.googlesource.com/1238989 Commit-Ready: Amin Hassani <[email protected]> Tested-by: Amin Hassani <[email protected]> Reviewed-by: Sen Jiang <[email protected]>
diff --git a/omaha_request_action_unittest.cc b/omaha_request_action_unittest.cc index 5b00238..4d412ac 100644 --- a/omaha_request_action_unittest.cc +++ b/omaha_request_action_unittest.cc
@@ -146,19 +146,16 @@ : "") + "</packages>" "<actions><action event=\"postinstall\" MetadataSize=\"11" + - (multi_package ? ":22" : "") + "\" ChromeOSVersion=\"" + version + - "\" MoreInfo=\"" + more_info_url + "\" Prompt=\"" + prompt + + (multi_package ? ":22" : "") + "\" MoreInfo=\"" + more_info_url + + "\" Prompt=\"" + prompt + "\" " - "IsDelta=\"true\" " "IsDeltaPayload=\"true" + (multi_package ? ":false" : "") + "\" " "MaxDaysToScatter=\"" + max_days_to_scatter + "\" " - "sha256=\"not-used\" " - "needsadmin=\"" + - needsadmin + "\" " + + "sha256=\"not-used\" " + (deadline.empty() ? "" : ("deadline=\"" + deadline + "\" ")) + (disable_p2p_for_downloading ? "DisableP2PForDownloading=\"true\" " : "") + @@ -201,7 +198,6 @@ string codebase2 = "http://code/base/2/"; string filename = "file.signed"; string hash = "4841534831323334"; - string needsadmin = "false"; uint64_t size = 123; string deadline = ""; string max_days_to_scatter = "7"; @@ -1642,12 +1638,9 @@ "<packages><package hash=\"not-used\" name=\"f\" " "size=\"587\" hash_sha256=\"lkq34j5345\"/></packages>" "<actions><action event=\"postinstall\" " - "ChromeOSVersion=\"10.2.3.4\" " "Prompt=\"false\" " - "IsDelta=\"true\" " "IsDeltaPayload=\"false\" " "sha256=\"not-used\" " - "needsadmin=\"true\" " "/></actions></manifest></updatecheck></app></response>"; LOG(INFO) << "Input Response = " << input_response;