Google Git
Sign in
android / platform / system / update_engine / 5c6bb1d8f89b87e782e26fe74789b6f510704394
commit5c6bb1d8f89b87e782e26fe74789b6f510704394[log] [tgz]
authorChih-Hung Hsieh <[email protected]>Wed Jul 27 13:33:15 2016 -0700
committerTreehugger Robot <[email protected]>Thu Jul 28 17:32:42 2016 +0000
tree9c177ad062ca0a25ea872e369d7e43fbd46afbed
parent87792ea818a63f2d246bbba2b7429b85ee8d669f [diff]
Fix clang-tidy performance warnings in update_engine.

* Use const reference type for parameters, local variables,
  and for-loop index variables to avoid unnecessary copy.
* Convert some for-loops to for-rang loops.

Bug: 30407689
Bug: 30413223
Bug: 30413862
Change-Id: I78996b3f799639fc57ced45e110807625be7dcce
Test: build with WITH_TIDY=1
15 files changed
tree: 9c177ad062ca0a25ea872e369d7e43fbd46afbed
  1. binder_bindings/
  2. client_library/
  3. common/
  4. dbus_bindings/
  5. include/
  6. init/
  7. payload_consumer/
  8. payload_generator/
  9. sample_images/
  10. scripts/
  11. update_manager/
  12. update_payload_key/
  13. weaved/
  14. .clang-format ⇨ ../../build/tools/brillo-clang-format
  15. .gitignore
  16. Android.mk
  17. binder_service_android.cc
  18. binder_service_android.h
  19. binder_service_brillo.cc
  20. binder_service_brillo.h
  21. boot_control_android.cc
  22. boot_control_android.h
  23. boot_control_chromeos.cc
  24. boot_control_chromeos.h
  25. boot_control_chromeos_unittest.cc
  26. chrome_browser_proxy_resolver.cc
  27. chrome_browser_proxy_resolver.h
  28. chrome_browser_proxy_resolver_unittest.cc
  29. common_service.cc
  30. common_service.h
  31. common_service_unittest.cc
  32. connection_manager.cc
  33. connection_manager.h
  34. connection_manager_android.cc
  35. connection_manager_android.h
  36. connection_manager_interface.h
  37. connection_manager_unittest.cc
  38. connection_utils.cc
  39. connection_utils.h
  40. daemon.cc
  41. daemon.h
  42. daemon_state_android.cc
  43. daemon_state_android.h
  44. daemon_state_interface.h
  45. dbus_connection.cc
  46. dbus_connection.h
  47. dbus_service.cc
  48. dbus_service.h
  49. dbus_test_utils.h
  50. fake_file_writer.h
  51. fake_p2p_manager.h
  52. fake_p2p_manager_configuration.h
  53. fake_shill_proxy.cc
  54. fake_shill_proxy.h
  55. fake_system_state.cc
  56. fake_system_state.h
  57. generate_pc_file.sh
  58. hardware_android.cc
  59. hardware_android.h
  60. hardware_chromeos.cc
  61. hardware_chromeos.h
  62. hardware_chromeos_unittest.cc
  63. image_properties.h
  64. image_properties_android.cc
  65. image_properties_chromeos.cc
  66. image_properties_chromeos_unittest.cc
  67. libcros_proxy.cc
  68. libcros_proxy.h
  69. libupdate_engine-client-test.pc.in
  70. libupdate_engine-client.pc.in
  71. local_coverage_rate
  72. main.cc
  73. metrics.cc
  74. metrics.h
  75. metrics_utils.cc
  76. metrics_utils.h
  77. metrics_utils_unittest.cc
  78. mock_connection_manager.h
  79. mock_file_writer.h
  80. mock_omaha_request_params.h
  81. mock_p2p_manager.h
  82. mock_payload_state.h
  83. mock_power_manager.h
  84. mock_proxy_resolver.h
  85. mock_update_attempter.h
  86. MODULE_LICENSE_APACHE2
  87. network_selector.h
  88. network_selector_android.cc
  89. network_selector_android.h
  90. network_selector_interface.h
  91. network_selector_stub.cc
  92. network_selector_stub.h
  93. NOTICE
  94. omaha_request_action.cc
  95. omaha_request_action.h
  96. omaha_request_action_unittest.cc
  97. omaha_request_params.cc
  98. omaha_request_params.h
  99. omaha_request_params_unittest.cc
  100. omaha_response.h
  101. omaha_response_handler_action.cc
  102. omaha_response_handler_action.h
  103. omaha_response_handler_action_unittest.cc
  104. omaha_utils.cc
  105. omaha_utils.h
  106. omaha_utils_unittest.cc
  107. OWNERS
  108. p2p_manager.cc
  109. p2p_manager.h
  110. p2p_manager_unittest.cc
  111. parcelable_update_engine_status.cc
  112. parcelable_update_engine_status.h
  113. payload_state.cc
  114. payload_state.h
  115. payload_state_interface.h
  116. payload_state_unittest.cc
  117. power_manager_android.cc
  118. power_manager_android.h
  119. power_manager_chromeos.cc
  120. power_manager_chromeos.h
  121. power_manager_interface.h
  122. PRESUBMIT.cfg
  123. proxy_resolver.cc
  124. proxy_resolver.h
  125. real_system_state.cc
  126. real_system_state.h
  127. run_unittests
  128. sample_omaha_v3_response.xml
  129. service_delegate_android_interface.h
  130. service_observer_interface.h
  131. shill_proxy.cc
  132. shill_proxy.h
  133. shill_proxy_interface.h
  134. system_state.h
  135. tar_bunzip2.gypi
  136. test_http_server.cc
  137. test_subprocess.cc
  138. testrunner.cc
  139. unittest_key.pem
  140. unittest_key2.pem
  141. update_attempter.cc
  142. update_attempter.h
  143. update_attempter_android.cc
  144. update_attempter_android.h
  145. update_attempter_unittest.cc
  146. update_engine-client.gyp
  147. update_engine.conf
  148. update_engine.gyp
  149. update_engine.rc
  150. update_engine_client.cc
  151. update_engine_client_android.cc
  152. update_metadata.proto
  153. update_status_utils.cc
  154. update_status_utils.h
  155. UpdateEngine.conf
  156. utils_android.cc
  157. utils_android.h
  158. WATCHLISTS
  159. weave_service.cc
  160. weave_service.h
  161. weave_service_factory.cc
  162. weave_service_factory.h
  163. weave_service_interface.h