tree 4c6907081ce2391d35e0611beb7dc316734a3620
parent 6ac968cceb0bdd1432386b1ffd8fae52065a6bbd
author Ben Caimano <bcaimano@cloudflare.com> 1642703482 -0500
committer Ben Caimano <bcaimano@cloudflare.com> 1643064246 -0500

Assert that HttpHeaders instances know about indexed ids

The HttpHeaderTable::Builder class allows you to reference its future table before it is fully built. But that HttpHeaderTable must be used to make HttpHeaders instances only after HttpHeaderTable::Builder::build() is invoked under peril of index out of bounds error in debug mode or segfault in release mode. These errors can be somewhat mysterious since they usually occur on a different stack from where the HttpHeaders instance was made. This commit adds an assertion that makes this situation more evident and logs useful diagnostic info about which header id was added after the construction. Hopefully, it should downgrade a segfault to failed Promise or thrown Exception for most users.