2021-06-30 Triage Log

We only have partial results this week (more details below). From the results we have collected, we have one small regression and several improvements. Also, there was a broad max-rss regression from 11 days ago. and narrower max-rss regression from 9 days ago.

This week we had some problems with missing benchmark results for some of the commits (we believe this is due to triagebot being out of service for a while). Thus, there is a gap from 5a7834050f3a0ebcd117b4ddf0bc1e8459594309 to 7c3872e6bfd555d2ad753ac1f871db3bd7f2a547.

The following PR's from that gap were omitted from this analysis.

  • #86467 - ChrisDenton:win-env-clear, r=JohnTitor
  • #85427 - ehuss:fix-use-placement, r=jackh726
  • #86279 - JohnTitor:transparent-zero-size-fields, r=nikomatsakis
  • #86588 - JohnTitor:rollup-ibgjbkf, r=JohnTitor
  • #86138 - FabianWolff:issue-85871, r=nikomatsakis
  • #86573 - Mark-Simulacrum:expat-bump, r=pietroalbini

We have manually enqueued the missing commits for benchmarking on perf.rlo.

Triage done by @pnkfelix. Revision range: 406d4a9cc3b9601cf98a07c6c83e0227d64f5d48..5a7834050f3a0ebcd117b4ddf0bc1e8459594309 Revision range: 7c3872e6bfd555d2ad753ac1f871db3bd7f2a547..7ede6e2a2359c1bb9032baffa4fdafe5633749e3

1 Regressions, 5 Improvements, 0 Mixed

1 of them in rollups

Regressions

Disambiguate between SourceFiles from different crates even if they have the same path #86368

  • Moderate regression in instruction counts (up to 1.2% on incr-unchanged builds of ctfe-stress-4-check)

Improvements

Add MIR pass to lower call to core::slice::len into Len operand #86383

  • Moderate improvement in instruction counts (up to -2.9% on incr-patched: Job builds of regex-debug)

Rollup of 11 pull requests #86527

  • Moderate improvement in instruction counts (up to -1.2% on incr-patched: b9b3e592dd cherry picked builds of style-servo-debug)

Derive Copy for VarianceDiagInfo #86670

  • Moderate improvement in instruction counts (up to -4.8% on full builds of wg-grammar-check)
  • Notably, this was in response to a nag re: a regression from #85343. Thanks @Aaron Hill!

Add inflate to pgo #86697

Change vtable memory representation to use tcx allocated allocations. #86475

  • Moderate improvement in instruction counts (up to -1.2% on incr-unchanged builds of ctfe-stress-4-check)

Mixed

Nags requiring follow up

  • Follow up on max-rss regression in #86034