2021-10-12 Triage Log

A relatively quiet week: two smallish regressions, and one largish regression that is isolated to doc builds. A couple of nice small wins as well.

Triage done by @pnkfelix. Revision range: 25ec8273855fde2d72ae877b397e054de5300e10..9475e609b8458fff9e444934a6017d2e590642cf

2 Regressions, 2 Improvements, 2 Mixed; 1 of them in rollups 42 comparisons made in total

Regressions

Rollup of 12 pull requests #89608

Moderate regression in instruction counts (up to 0.8% on incr-unchanged builds of externs)
A large number of doc targets regressed very slightly here.
Apart from that, biggest changes were to externs and deeply-nested-async.
Left comment noting the above

Move top part of print_item to Tera templates #89695

Large regression in instruction counts (up to 3.7% on full builds of externs)
Large regression for certain doc builds.
Fix posted in PR #89732; thanks @GuillaumeGomez !

Apply clippy suggestions for rustc and core #89709

Large regression in instruction counts (up to 2.8% on full builds of keccak)
instruction-count regressions in the 1.1% to 2.7% range in keccak and inflate
Left comment

Improvements

perf: only check for rustc_trivial_field_reads attribute on traits, not items, impls, etc. #89454

Moderate improvement in instruction counts (up to -0.8% on incr-unchanged builds of derive)

rustdoc: Cleanup various clean types #88379

Moderate improvement in instruction counts (up to -0.8% on full builds of issue-46449)

Mixed

Add two inline annotations for hot functions #89495

Very large improvement in instruction counts (up to -7.1% on full builds of inflate)
Small regression in instruction counts (up to 0.4% on incr-unchanged builds of helloworld)

Introduce tcx.get_diagnostic_name #89534

Large improvement in instruction counts (up to -3.4% on incr-full builds of ctfe-stress-4)
Small regression in instruction counts (up to 0.4% on incr-unchanged builds of helloworld)

Untriaged Pull Requests