2022-03-09 Triage Log
A pretty smooth week. All three regressions were small, and two were isolated to rustdoc alone.
Triage done by @pnkfelix. Revision range: f0c4da49983aa699f715caf681e3154b445fb60b..10dccdc7fcbdc64ee9efe2c1ed975ab8c1d61287
3 Regressions, 3 Improvements, 1 Mixed; 2 of them in rollups 53 comparisons made in total
Regressions
Rollup of 9 pull requests #94541
- Arithmetic mean of relevant regressions: 1.5%
- Largest regression in instruction counts: 3.9% on
full builds of deeply-nested-async check - After looking at the performance data, it seems like the regressions to
deeply-nested-async are isolated to some slowdown in check_mod_privacy. - But AFAICT nothing in this rollup should have affected
check_mod_privacy. - Chalking this up to optimization noise; marked as triaged.
Support GATs in Rustdoc #94009
- Arithmetic mean of relevant regressions: 0.8%
- Largest regression in instruction counts: 1.1% on
full builds of ctfe-stress-4 doc - Already marked as triaged by rustdoc team; this change makes rustdoc track more data, which inevitably leads to perf regressions.
rustdoc: Stop textually replacing Self in doc links before resolving them #93805
- Arithmetic mean of relevant regressions: 0.3%
- Arithmetic mean of all relevant changes: 0.3%
- Largest regression in instruction counts: 1.0% on
full builds of serde doc - rustdoc team did not expect a regression here.
- it looks like collect-intra-doc-links got slower. not clear why, though.
- slowdown was solely observed in
serde doc. posted some theories and marked as triaged.
Improvements
remove obligation dedup from impl_or_trait_obligations #84944
- Arithmetic mean of relevant improvements: -1.4%
- Largest improvement in instruction counts: -4.0% on
full builds of deeply-nested check
Introduce ConstAllocation. #94597
- Arithmetic mean of relevant improvements: -0.9%
- Arithmetic mean of all relevant changes: -0.8%
- Largest improvement in instruction counts: -1.4% on
full builds of keccak check
Rollup of 6 pull requests #94761
- Arithmetic mean of relevant improvements: -1.1%
- Largest improvement in instruction counts: -1.2% on
full builds of token-stream-stress check
Mixed
Reopen 91719 #94570
- Arithmetic mean of relevant regressions: 0.5%
- Arithmetic mean of relevant improvements: -1.4%
- Arithmetic mean of all relevant changes: -1.0%
- Largest improvement in instruction counts: -6.9% on
full builds of deeply-nested-async check - Largest regression in instruction counts: 1.3% on
incr-full builds of piston-image opt - Already triaged by workingjubilee when they r+'ed it.
Untriaged Pull Requests
- #94541 Rollup of 9 pull requests
- #94402 Revert “Auto merge of #92419 - erikdesjardins:coldland, r=nagisa”
- #94333 Rollup of 9 pull requests
- #94130 Use undef for (some) partially-uninit constants
- #94103 Rollup of 9 pull requests
- #94072 Rollup of 8 pull requests
- #93805 rustdoc: Stop textually replacing
Self in doc links before resolving them - #93670 Apply noundef attribute to &T, &mut T, Box, bool
- #93505 safely
transmute<&List<Ty<'tcx>>, &List<GenericArg<'tcx>>> - #93466 Make dead code check a query.
- #93312 Return an indexmap in
all_local_trait_impls query - #93298 make
find_similar_impl_candidates even fuzzier - #93288 Rollup of 8 pull requests
- #93154 debuginfo: Make sure that type names for closure and generator environments are unique in debuginfo.
- #93148 Overhaul interning.
- #93138 Rollup of 17 pull requests
- #93095 Store a
Symbol instead of an Ident in AssocItem - #92911 Guard against unwinding in cleanup code
- #92896 Update some rustc dependencies to deduplicate them
- #92844 Rollup of 9 pull requests
- #92816 Remove deprecated LLVM-style inline assembly
- #92805 partially revertish
lazily "compute" anon const default substs - #92535 Allow unwinding from OOM hooks
- #92534 Hash
Ident spans in all HIR structures - #92356 Add {Add,Sub,Mul,Div,Rem,BitXor,BitOr,BitAnd}{,Assign}<$t> to Saturat…
- #92277 rustc_metadata: Stop passing
CrateMetadataRef by reference (step 1) - #92252 Update pulldown-cmark version to 0.9
- #92229 Do not display
~const Drop in rustdoc - #92227 Rustdoc: use
is_doc_hidden method on more places - #92149 Fix bad caching of
~const Drop bounds
Nags requiring follow up
TODO: Nags