2022-11-14 Triage Log

A light week for triage. The biggest of the three regressions has a (hopeful) fix up already. The second biggest is a regression we are accepting for sake of correctness of incremental-compilation. The third regression is small and may well be removed as the type system internals are improved. max-rss seems stable.

Triage done by @pnkfelix. Revision range: 57d3c58e..96ddd32c

Summary:

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.7%[0.2%, 1.4%]87
Regressions ❌
(secondary)		0.7%[0.2%, 2.3%]36
Improvements ✅
(primary)		-0.5%[-1.2%, -0.3%]12
Improvements ✅
(secondary)		-0.9%[-2.0%, -0.2%]9
All ❌✅ (primary)0.5%[-1.2%, 1.4%]99

3 Regressions, 4 Improvements, 3 Mixed; 2 of them in rollups 40 artifact comparisons made in total

Regressions

Better error for HRTB error from generator interior #103171 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		1.6%[1.3%, 2.1%]6
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0
  • Already triaged (by two different people).
  • Also, according to comment thread, this change is slated to be removed once binders support implied bounds, so even if there is a minor regression attached to this PR, the PR should nonetheless go away eventually.

Recover wrong-cased keywords that start items #99918 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.6%[0.2%, 1.2%]80
Regressions ❌
(secondary)		0.8%[0.3%, 1.4%]11
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.6%[0.2%, 1.2%]80

Hash spans when interning types #104282 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.5%[0.2%, 0.9%]44
Regressions ❌
(secondary)		0.6%[0.2%, 0.9%]19
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.5%[0.2%, 0.9%]44
  • already triaged; its a regression we are accepting for sake of correctness

Improvements

Remove allow(rustc::potential_query_instability) in rustc_trait_selection #103723 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.5%[-0.5%, -0.5%]1
Improvements ✅
(secondary)		-0.8%[-1.0%, -0.5%]7
All ❌✅ (primary)-0.5%[-0.5%, -0.5%]1

Rollup of 9 pull requests #104236 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.3%[-0.4%, -0.2%]21
Improvements ✅
(secondary)		-0.3%[-0.6%, -0.2%]12
All ❌✅ (primary)-0.3%[-0.4%, -0.2%]21

Rollup of 9 pull requests #104246 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.7%[-0.8%, -0.6%]3
Improvements ✅
(secondary)		-0.5%[-0.6%, -0.3%]4
All ❌✅ (primary)-0.7%[-0.8%, -0.6%]3

Retry failed macro matching for diagnostics #103898 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.8%[-1.3%, -0.3%]11
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.8%[-1.3%, -0.3%]11

Mixed

resolve: More detailed effective visibility tracking for imports #103965 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.3%[0.2%, 0.4%]4
Regressions ❌
(secondary)		0.3%[0.2%, 0.4%]5
Improvements ✅
(primary)		-0.2%[-0.2%, -0.2%]3
Improvements ✅
(secondary)		-0.5%[-1.1%, -0.4%]9
All ❌✅ (primary)0.1%[-0.2%, 0.4%]7
  • This is an internal refactoring that we need to get more precise tracking of imports in presence of globs.
  • treating the regressions as acceptable; marked it as triaged.

rustc_codegen_ssa: Better code generation for niche discriminants. #102872 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.5%[0.5%, 0.6%]2
Regressions ❌
(secondary)		2.1%[2.1%, 2.1%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-1.3%[-2.2%, -0.3%]4
All ❌✅ (primary)0.5%[0.5%, 0.6%]2
  • already triaged

Merge crossbeam-channel into std::sync::mpsc #93563 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.8%[0.4%, 1.1%]5
Regressions ❌
(secondary)		0.5%[0.5%, 0.5%]1
Improvements ✅
(primary)		-0.7%[-1.1%, -0.3%]3
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.2%[-1.1%, 1.1%]8
  • already triaged

Untriaged Pull Requests