2022-12-20 Triage Log

Relatively quiet week for performance, with most regressions and improvements being pretty small.

Triage done by @simulacrum. Revision range: 109cccbe4f345c0f0785ce860788580c3e2a29f5..8a746f4ac3a489efb724cde813607f3b96c2df7b

Summary:

(instructions:u)	mean	range	count
Regressions ❌ (primary)	0.9%	[0.2%, 2.8%]	28
Regressions ❌ (secondary)	0.7%	[0.2%, 1.3%]	39
Improvements ✅ (primary)	-1.0%	[-1.1%, -1.0%]	2
Improvements ✅ (secondary)	-1.7%	[-4.3%, -0.2%]	24
All ❌✅ (primary)	0.8%	[-1.1%, 2.8%]	30

3 Regressions, 4 Improvements, 2 Mixed; 3 of them in rollups 53 artifact comparisons made in total

Regressions

use ty::Binder in rustdoc instead of skip_binder #105612 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	5
Regressions ❌ (secondary)	0.5%	[0.3%, 0.7%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.5%]	5

The regressions are expected, solely in rustdoc and part of a bugfix.

Use non-ascribed type as field's type in mir #103880 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[2.5%, 3.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Regression does not appear to be noise, however the PR in question has been reverted (due to non-perf regressions).

Add IMPLIED_BOUNDS_ENTAILMENT lint #105575 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	0.9%	[0.2%, 2.3%]	20
Regressions ❌ (secondary)	1.6%	[0.6%, 2.6%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.2%, 2.3%]	20

New lint for a soundness fix. Regressions relatively limited regardless.

Improvements

Revert “enable ThinLTO for rustc on x86_64-apple-darwin dist builds” #105646 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.1%, -0.9%]	2
Improvements ✅ (secondary)	-2.0%	[-2.6%, -0.8%]	7
All ❌✅ (primary)	-1.0%	[-1.1%, -0.9%]	2

Rollup of 5 pull requests #105892 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.1%, -0.9%]	2
Improvements ✅ (secondary)	-2.2%	[-2.6%, -2.0%]	6
All ❌✅ (primary)	-1.0%	[-1.1%, -0.9%]	2

Revert #103880 “Use non-ascribed type as field's type in mir” #105905 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.3%, -0.3%]	5
Improvements ✅ (secondary)	-1.7%	[-3.5%, -0.4%]	14
All ❌✅ (primary)	-0.7%	[-1.3%, -0.3%]	5

Rollup of 5 pull requests #105940 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.0%]	2
Improvements ✅ (secondary)	-1.7%	[-2.6%, -0.4%]	9
All ❌✅ (primary)	-1.1%	[-1.1%, -1.0%]	2

Mixed

Guard ProjectionTy creation against passing the wrong number of substs #105657 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[0.7%, 1.2%]	9
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.1%]	2
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.5%]	8
All ❌✅ (primary)	-0.4%	[-0.6%, -0.1%]	2

Rollup of 7 pull requests #105918 (Comparison Link)

(instructions:u)	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-4.4%, -0.8%]	12
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1