A very quiet week, with few changes in either direction, and none of significant magnitude.
Triage done by @simulacrum. Revision range: b435960c4cfd3975651c7051be56d7f5d6c201ab..0442fbabe24ec43636a80ad1f40a0ad92a2e38df
Summary:
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 1.2% | [0.5%, 1.9%] | 2 |
| Regressions ❌ (secondary) | 1.1% | [0.5%, 1.3%] | 10 |
| Improvements ✅ (primary) | -0.7% | [-1.2%, -0.5%] | 7 |
| Improvements ✅ (secondary) | -0.5% | [-0.7%, -0.2%] | 7 |
| All ❌✅ (primary) | -0.3% | [-1.2%, 1.9%] | 9 |
1 Regressions, 1 Improvements, 3 Mixed; 1 of them in rollups 48 artifact comparisons made in total
Rollup of 10 pull requests #106573 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.3% | [0.2%, 0.3%] | 4 |
| Regressions ❌ (secondary) | 0.5% | [0.3%, 1.0%] | 22 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 4 |
Migrating rustc_infer to session diagnostics (part 3) #101936 seems to be the cause of the regression, but no investigation has happened yet.
Remove duplicated elaborate box derefs pass #106404 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 1.2% | [1.2%, 1.2%] | 2 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -0.3% | [-0.3%, -0.2%] | 7 |
| All ❌✅ (primary) | - | - | 0 |
Single regression is within noise range; improvements are not. Removing perf-regression.
Shrink ParseResult in the hot path. #106416 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
| Improvements ✅ (primary) | -0.4% | [-0.5%, -0.3%] | 7 |
| Improvements ✅ (secondary) | -0.4% | [-0.5%, -0.4%] | 4 |
| All ❌✅ (primary) | -0.4% | [-0.5%, -0.3%] | 7 |
Improvements include primary benchmarks and outweigh regressions.
Perform SimplifyLocals before ConstProp. #105323 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.7% | [0.2%, 1.6%] | 4 |
| Regressions ❌ (secondary) | 0.6% | [0.6%, 0.6%] | 1 |
| Improvements ✅ (primary) | -0.6% | [-0.8%, -0.5%] | 4 |
| Improvements ✅ (secondary) | -0.5% | [-0.5%, -0.5%] | 1 |
| All ❌✅ (primary) | 0.0% | [-0.8%, 1.6%] | 8 |
Regressions did not occur in a pre-merge run, asked whether changes made after it could have led to the regressions.
Don't normalize in AstConv #101947 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.1% | [0.1%, 0.1%] | 1 |
| Regressions ❌ (secondary) | 0.2% | [0.2%, 0.2%] | 3 |
| Improvements ✅ (primary) | -1.0% | [-1.0%, -1.0%] | 1 |
| Improvements ✅ (secondary) | -0.8% | [-0.9%, -0.8%] | 7 |
| All ❌✅ (primary) | -0.5% | [-1.0%, 0.1%] | 2 |