2023-01-18 Triage Log

Nearly all flagged regressions are likely noise, except one rollup with minor impact on diesel that we will follow up on. We had a broad (albeit small) win from #106294.

Triage done by @pnkfelix. Revision range: 0442fbabe24ec43636a80ad1f40a0ad92a2e38df..1f72129ffe5e8c495113f9a2d4e1730f7fad3209

Summary:

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.4%[0.2%, 1.7%]39
Regressions ❌
(secondary)		0.5%[0.2%, 1.8%]23
Improvements ✅
(primary)		-0.4%[-0.6%, -0.2%]7
Improvements ✅
(secondary)		-0.4%[-0.6%, -0.2%]6
All ❌✅ (primary)0.3%[-0.6%, 1.7%]46

4 Regressions, 3 Improvements, 3 Mixed; 4 of them in rollups 50 artifact comparisons made in total

Regressions

Rollup of 9 pull requests #106730 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.3%[0.2%, 0.3%]6
Regressions ❌
(secondary)		0.4%[0.2%, 0.7%]4
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.3%[0.2%, 0.3%]6
  • already isolated by the PR author to #106321
  • left comment and marked as triaged

Rollup of 10 pull requests #106822 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.8%[0.8%, 0.9%]4
Regressions ❌
(secondary)		0.5%[0.3%, 0.8%]12
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.8%[0.8%, 0.9%]4
  • the sole primary impacted benchmarks are variants of helloworld-check.
  • Looking at the graph, I'm categorizing this as noise.
  • left comment and marked as triaged

Rework some predicates_of/{Generic,Instantiated}Predicates code #106395 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.8%[0.7%, 0.9%]4
Regressions ❌
(secondary)		0.6%[0.2%, 1.1%]18
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.7%[-0.7%, -0.7%]1
All ❌✅ (primary)0.8%[0.7%, 0.9%]4
  • already triaged as noise

Heuristically undo path prefix mappings. #106853 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.7%[0.7%, 0.8%]3
Regressions ❌
(secondary)		0.4%[0.3%, 0.6%]9
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.7%[0.7%, 0.8%]3
  • From the graph, I think this is just noise
  • left comment and marked as triaged

Improvements

Update cargo #106825 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.9%[-0.9%, -0.8%]4
Improvements ✅
(secondary)		-0.5%[-0.8%, -0.3%]12
All ❌✅ (primary)-0.9%[-0.9%, -0.8%]4
  • just noise in the other direction

Emit only one nbsp error per file #106872 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.7%[-0.8%, -0.7%]4
Improvements ✅
(secondary)		-0.6%[-1.1%, -0.3%]15
All ❌✅ (primary)-0.7%[-0.8%, -0.7%]4
  • just noise in the other direction

Put noundef on all scalars that don't allow uninit #106294 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.6%[0.5%, 0.6%]2
Regressions ❌
(secondary)		1.2%[1.2%, 1.2%]1
Improvements ✅
(primary)		-0.2%[-0.3%, -0.1%]52
Improvements ✅
(secondary)		-0.3%[-0.5%, -0.2%]24
All ❌✅ (primary)-0.2%[-0.3%, 0.6%]54
  • awesome amount of green (small but broad) in the per fresults

Mixed

Rollup of 10 pull requests #106757 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.6%[0.6%, 0.7%]6
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.5%[-0.5%, -0.5%]1
All ❌✅ (primary)0.6%[0.6%, 0.7%]6
  • the regressing cases are all variation of diesel {full, incr-full}
  • Not marking #106757 as triaged. Doing some rust-timer runs on the individual builds.

Rollup of 10 pull requests #106851 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.4%[0.3%, 0.5%]5
Improvements ✅
(primary)		-0.4%[-0.4%, -0.3%]4
Improvements ✅
(secondary)		-0.4%[-0.6%, -0.1%]3
All ❌✅ (primary)-0.4%[-0.4%, -0.3%]4
  • the regressing cases are secondary tuple-stress and deep-vector
  • left comment and marked as triaged.

Switch to EarlyBinder for const_param_default and impl_trait_ref queries #106696 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.2%[0.2%, 0.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.3%[-0.4%, -0.2%]3
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.2%[-0.4%, 0.2%]4
  • there is one small regression to bitmaps-full doc, and three improvements to bitmaps-incr-full {check, debug, opt}.
  • If its not noise, its seems like the right trade off.
  • left comment, marked as triaged.

Untriaged Pull Requests