The last two weeks mostly have small changes across a number of benchmarks, no widespread large regressions or improvements.
Triage done by @simulacrum. Revision range: a368898d..3ea9ad532
Summary:
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.9% | [0.2%, 2.0%] | 96 |
| Regressions ❌ (secondary) | 1.1% | [0.2%, 3.2%] | 60 |
| Improvements ✅ (primary) | -1.3% | [-4.4%, -0.3%] | 10 |
| Improvements ✅ (secondary) | -3.3% | [-7.2%, -0.6%] | 16 |
| All ❌✅ (primary) | 0.6% | [-4.4%, 2.0%] | 106 |
6 Regressions, 3 Improvements, 4 Mixed; 2 of them in rollups 90 artifact comparisons made in total
Rollup of 6 pull requests #111248 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 0.8% | [0.5%, 1.6%] | 11 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Minor regression limited to the coercion benchmark.
Populate effective visibilities in ‘rustc_privacy’ #110907 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.5% | [0.2%, 1.6%] | 72 |
| Regressions ❌ (secondary) | 0.5% | [0.2%, 1.2%] | 15 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.5% | [0.2%, 1.6%] | 72 |
Populate effective visibilities in rustc_privacy (take 2) #111425 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.7% | [0.4%, 1.5%] | 25 |
| Regressions ❌ (secondary) | 0.6% | [0.3%, 1.0%] | 10 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.7% | [0.4%, 1.5%] | 25 |
#111260 addresses performance regressions in these two PRs.
Disable nrvo mir opt #111007 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.5% | [0.2%, 2.1%] | 109 |
| Regressions ❌ (secondary) | 0.5% | [0.1%, 0.9%] | 55 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.5% | [0.2%, 2.1%] | 109 |
Disables an optimization known to have miscompilations. Eventually we should re-land something that has similar benefits.
Use dynamic dispatch for queries #108638 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.6% | [0.3%, 1.0%] | 74 |
| Regressions ❌ (secondary) | 0.7% | [0.1%, 2.2%] | 61 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.6% | [0.3%, 1.0%] | 74 |
Cuts bootstrap compile times (33% win for rustc_query_impl), some further work is expected to regain some of the lost performance.
Combine three generalizer implementations #111221 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.5% | [0.3%, 0.8%] | 11 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.5% | [0.3%, 0.8%] | 11 |
Regression is relatively small and plausibly due to slight optimization changes; did not occur in original perf run.
Restrict From<S> for {D,Subd}iagnosticMessage. #110579 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.5% | [-0.5%, -0.4%] | 3 |
| Improvements ✅ (secondary) | -0.6% | [-0.8%, -0.5%] | 5 |
| All ❌✅ (primary) | -0.5% | [-0.5%, -0.4%] | 3 |
Rollup of 6 pull requests #111414 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -5.7% | [-5.7%, -5.7%] | 1 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | -5.7% | [-5.7%, -5.7%] | 1 |
Align unsized locals #111374 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.4% | [-0.4%, -0.4%] | 2 |
| Improvements ✅ (secondary) | -0.5% | [-0.7%, -0.3%] | 5 |
| All ❌✅ (primary) | -0.4% | [-0.4%, -0.4%] | 2 |
Update hashbrown from 0.12.3 to 0.13.1 for std #111306 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.4% | [0.4%, 0.4%] | 1 |
| Regressions ❌ (secondary) | 0.6% | [0.2%, 1.0%] | 2 |
| Improvements ✅ (primary) | -0.3% | [-0.4%, -0.2%] | 4 |
| Improvements ✅ (secondary) | -0.6% | [-0.8%, -0.5%] | 4 |
| All ❌✅ (primary) | -0.1% | [-0.4%, 0.4%] | 5 |
Uplift clippy::{drop,forget}_{ref,copy} lints #109732 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | 0.5% | [0.4%, 0.8%] | 5 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -1.4% | [-1.9%, -1.0%] | 4 |
| All ❌✅ (primary) | 0.5% | [0.4%, 0.8%] | 5 |
Remove useless assumes from slice::iter(_mut) #111447 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 1.1% | [1.1%, 1.1%] | 2 |
| Improvements ✅ (primary) | -0.8% | [-1.7%, -0.3%] | 85 |
| Improvements ✅ (secondary) | -0.7% | [-1.4%, -0.4%] | 46 |
| All ❌✅ (primary) | -0.8% | [-1.7%, -0.3%] | 85 |
Fix the FileEncoder buffer size. #111088 (Comparison Link)
| (instructions:u) | mean | range | count |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.1% | [2.1%, 2.1%] | 1 |
| Improvements ✅ (primary) | -0.3% | [-0.5%, -0.3%] | 10 |
| Improvements ✅ (secondary) | -0.4% | [-0.7%, -0.2%] | 12 |
| All ❌✅ (primary) | -0.3% | [-0.5%, -0.3%] | 10 |