2023-08-22 Triage Log

A week with very few real regressions and some good improvements through work done by @cjgillot who found a few spots where the compiler was doing unnecessary work.

Triage done by @rylev. Revision range: e845910..d4a881

Summary:

(instructions:u)meanrangecount
Regressions ❌
(primary)		1.4%[0.5%, 2.6%]13
Regressions ❌
(secondary)		0.6%[0.3%, 0.8%]8
Improvements ✅
(primary)		-0.7%[-1.4%, -0.3%]59
Improvements ✅
(secondary)		-0.8%[-1.3%, -0.3%]38
All ❌✅ (primary)-0.3%[-1.4%, 2.6%]72

3 Regressions, 2 Improvements, 2 Mixed; 2 of them in rollups 28 artifact comparisons made in total

Regressions

Warn on inductive cycle in coherence leading to impls being considered not overlapping #114023 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		1.3%[0.6%, 2.5%]10
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)1.3%[0.6%, 2.5%]10
  • The author is investigating whether this is due to the use of a temporary lint or if there is some more fundamental change happening here.

Rollup of 7 pull requests #114879 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.3%[0.3%, 0.3%]2
Regressions ❌
(secondary)		0.5%[0.4%, 0.6%]8
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.3%[0.3%, 0.3%]2
  • The perf result seems to just be noise.

Remove conditional use of Sharded from query caches #114892 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.4%[0.2%, 0.5%]3
Regressions ❌
(secondary)		0.5%[0.4%, 0.6%]8
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.4%[0.2%, 0.5%]3
  • Perf results are small and worth the simplification in code.

Improvements

Do not mark shallow_lint_levels_on as eval_always. #114536 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.4%[0.4%, 0.4%]1
Improvements ✅
(primary)		-0.7%[-1.3%, -0.3%]30
Improvements ✅
(secondary)		-0.5%[-1.0%, -0.3%]15
All ❌✅ (primary)-0.7%[-1.3%, -0.3%]30

Only run MaybeInitializedPlaces dataflow once to elaborate drops #111555 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.6%[0.6%, 0.6%]1
Improvements ✅
(primary)		-0.8%[-1.3%, -0.3%]27
Improvements ✅
(secondary)		-0.7%[-1.1%, -0.4%]32
All ❌✅ (primary)-0.8%[-1.3%, -0.3%]27

Mixed

add a csky-unknown-linux-gnuabiv2 target #113658 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		1.3%[0.3%, 1.9%]3
Regressions ❌
(secondary)		0.3%[0.3%, 0.3%]1
Improvements ✅
(primary)		-0.3%[-0.3%, -0.2%]4
Improvements ✅
(secondary)		-0.3%[-0.4%, -0.2%]4
All ❌✅ (primary)0.4%[-0.3%, 1.9%]7
  • Noise

Rollup of 10 pull requests #114852 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.5%[0.5%, 0.6%]4
Regressions ❌
(secondary)		1.0%[1.0%, 1.0%]3
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.5%[0.5%, 0.6%]4
  • Noise