2023-09-19 Triage Log

A pretty quiet week, with relatively few statistically significant changes, though some good improvements to a number of benchmarks, particularly in cycle counts rather than instructions.

Triage done by @simulacrum. Revision range: 7e0261e7ea2085bdc0bc3d0fd6776bf343473858..af78bae565e85b9c5698ee909af0652674eca6d4

Summary:

(instructions:u)meanrangecount
Regressions ❌
(primary)
0.5%[0.3%, 0.8%]14
Regressions ❌
(secondary)
0.5%[0.2%, 0.8%]5
Improvements ✅
(primary)
-1.2%[-6.4%, -0.3%]22
Improvements ✅
(secondary)
-2.1%[-8.1%, -0.2%]37
All ❌✅ (primary)-0.5%[-6.4%, 0.8%]36

3 Regressions, 3 Improvements, 2 Mixed; 2 of them in rollups 56 artifact comparisons made in total

Regressions

Accept additional user-defined syntax classes in fenced code blocks #110800 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)
0.7%[0.5%, 0.9%]3
Regressions ❌
(secondary)
0.9%[0.5%, 1.4%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.7%[0.5%, 0.9%]3

Some slight regressions, limited to doc benchmarks, for a new feature in rustdoc.

Store a index per dep node kind #115733 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)
0.4%[0.2%, 0.5%]9
Regressions ❌
(secondary)
0.3%[0.2%, 0.5%]6
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.4%[0.2%, 0.5%]9

Slight instruction regressions but overall an improvement -- max-rss and cycle counts are both down in aggregate.

Improvements

Rollup of 6 pull requests #115909 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.6%[-1.0%, -0.5%]6
Improvements ✅
(secondary)
-1.1%[-1.5%, -0.4%]19
All ❌✅ (primary)-0.6%[-1.0%, -0.5%]6

Rollup of 8 pull requests #115929 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)
0.2%[0.2%, 0.2%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.5%[-0.7%, -0.2%]19
Improvements ✅
(secondary)
-0.5%[-0.6%, -0.2%]12
All ❌✅ (primary)-0.4%[-0.7%, 0.2%]20

move required_consts check to general post-mono-check function #115748 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.5%[0.5%, 0.5%]1
Improvements ✅
(primary)
-5.0%[-6.3%, -3.6%]2
Improvements ✅
(secondary)
-6.1%[-6.6%, -5.7%]6
All ❌✅ (primary)-5.0%[-6.3%, -3.6%]2

Cache reachable_set on disk #115740 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)
0.4%[0.4%, 0.4%]1
Regressions ❌
(secondary)
0.4%[0.4%, 0.6%]4
Improvements ✅
(primary)
-1.0%[-2.4%, -0.3%]8
Improvements ✅
(secondary)
-2.6%[-8.2%, -0.8%]4
All ❌✅ (primary)-0.9%[-2.4%, 0.4%]9

Regressions are actually just noise, so moved this to improvements.