2024-04-16 Triage Log

A quiet week, with slightly more improvements than regressions. There were a few noise spikes, but other than that nothing too interesting.

Triage done by @Kobzol. Revision range: 86b603cd..ccfcd950b

Summary:

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.5%[0.3%, 1.4%]9
Regressions ❌
(secondary)		0.4%[0.2%, 1.1%]20
Improvements ✅
(primary)		-0.6%[-2.5%, -0.2%]41
Improvements ✅
(secondary)		-0.8%[-1.4%, -0.2%]4
All ❌✅ (primary)-0.4%[-2.5%, 1.4%]50

1 Regression, 3 Improvements, 6 Mixed; 5 of them in rollups 62 artifact comparisons made in total

Regressions

Implement syntax for impl Trait to specify its captures explicitly (feature(precise_capturing)) #123468 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.2%[0.2%, 0.2%]5
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.2%[0.2%, 0.2%]5
  • A tiny regression on a stress test, introduced by a new feature.
  • Marked as triaged.

Improvements

Remove my scalar_copy_backend_type optimization attempt #123185 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.7%[-0.7%, -0.7%]4
Improvements ✅
(secondary)		-2.0%[-2.7%, -1.2%]2
All ❌✅ (primary)-0.7%[-0.7%, -0.7%]4

Rollup of 8 pull requests #123823 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.4%[-1.1%, -0.2%]20
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.4%[-1.1%, -0.2%]20

Rollup of 4 pull requests #123982 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.6%[-0.8%, -0.3%]8
Improvements ✅
(secondary)		-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)-0.6%[-0.8%, -0.3%]8

Mixed

Only collect mono items from reachable blocks #123272 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.4%[0.2%, 1.5%]8
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.8%[-1.5%, -0.3%]6
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.1%[-1.5%, 1.5%]14
  • Fixed an important bug, and results were mixed anyway.

Rollup of 7 pull requests #123725 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.2%[0.2%, 0.2%]2
Regressions ❌
(secondary)		0.9%[0.2%, 2.6%]7
Improvements ✅
(primary)		-0.4%[-0.6%, -0.2%]2
Improvements ✅
(secondary)		-0.6%[-0.6%, -0.6%]1
All ❌✅ (primary)-0.1%[-0.6%, 0.2%]4
  • The largest regressions were noise, the rest was mixed.
  • Marked as triaged.

Rollup of 8 pull requests #123762 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.4%[0.2%, 0.5%]2
Regressions ❌
(secondary)		0.5%[0.3%, 1.7%]9
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.8%[-4.2%, -1.4%]2
All ❌✅ (primary)0.4%[0.2%, 0.5%]2
  • The largest regression on the coercions benchmark is noise.
  • The rest were small regressions on doc benchmarks.
  • Marked as triaged.

Rollup of 4 pull requests #123884 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.4%[0.4%, 0.4%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-1.0%[-1.0%, -1.0%]1
Improvements ✅
(secondary)		-0.3%[-0.3%, -0.3%]6
All ❌✅ (primary)-0.3%[-1.0%, 0.4%]2
  • The single regression was immediately reverted, the rest were small improvements.
  • Marked as triaged.

Re-enable has_thread_local for i686-msvc #123257 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.3%[0.3%, 0.4%]6
Improvements ✅
(primary)		-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1
  • This has to be noise, since the PR did not modify x64 Linux.

Get rid of USIZE_MARKER in formatting infrastructure #123819 (Comparison Link)

(instructions:u)meanrangecount
Regressions ❌
(primary)		0.6%[0.4%, 0.9%]2
Regressions ❌
(secondary)		1.5%[1.5%, 1.5%]1
Improvements ✅
(primary)		-0.4%[-0.6%, -0.3%]5
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.1%[-0.6%, 0.9%]7
  • More improvements than regressions.