commit 0d29b957dc21ed160e9dba0a880742f571ad0034
author Bartłomiej Grzesik <bgrzesik@google.com> Mon Aug 12 12:31:43 2024 +0000
committer Bartłomiej Grzesik <bgrzesik@google.com> Mon Aug 12 13:19:03 2024 +0000
tree 86babdd3142c05a224f135e9b370ea6b3ba21f3c
parent 19864ddb0f7d1d635cca146443a53c59efe2c49d

components: Add traces to EncodeComponent

This commit adds some traces to EncodeComponent in order to help
debug performance of the video encoding.

Bug: 351099322
Test: Recorded perfetto trace
Change-Id: I486ec6c2d895e83c3fc93d100a6afaf2cdb455c0

components/EncodeComponent.cpp

diff --git a/components/EncodeComponent.cpp b/components/EncodeComponent.cpp
index 0c7d044..d24ffd9 100644
--- a/components/EncodeComponent.cpp
+++ b/components/EncodeComponent.cpp
@@ -3,6 +3,7 @@
 // found in the LICENSE file
 
 //#define LOG_NDEBUG 0
+#define ATRACE_TAG ATRACE_TAG_VIDEO
 #define LOG_TAG "EncodeComponent"
 
 #include <v4l2_codec2/components/EncodeComponent.h>
@@ -22,6 +23,7 @@
 #include <media/stagefright/MediaDefs.h>
 #include <ui/GraphicBuffer.h>
 #include <ui/Size.h>
+#include <utils/Trace.h>
 
 #include <v4l2_codec2/common/EncodeHelpers.h>
 #include <v4l2_codec2/common/FormatConverter.h>
@@ -384,6 +386,7 @@
 }
 
 void EncodeComponent::startTask(bool* success, ::base::WaitableEvent* done) {
+    ATRACE_CALL();
     ALOGV("%s()", __func__);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
 
@@ -392,6 +395,7 @@
 }
 
 void EncodeComponent::stopTask(::base::WaitableEvent* done) {
+    ATRACE_CALL();
     ALOGV("%s()", __func__);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
 
@@ -412,6 +416,7 @@
 }
 
 void EncodeComponent::queueTask(std::unique_ptr<C2Work> work) {
+    ATRACE_CALL();
     ALOGV("%s()", __func__);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
     ALOG_ASSERT(mEncoder);
@@ -594,6 +599,7 @@
 
 void EncodeComponent::flushTask(::base::WaitableEvent* done,
                                 std::list<std::unique_ptr<C2Work>>* const flushedWork) {
+    ATRACE_CALL();
     ALOGV("%s()", __func__);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
 
@@ -621,6 +627,7 @@
 }
 
 bool EncodeComponent::updateEncodingParameters() {
+    ATRACE_CALL();
     ALOGV("%s()", __func__);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
 
@@ -683,6 +690,7 @@
 }
 
 bool EncodeComponent::encode(C2ConstGraphicBlock block, uint64_t index, int64_t timestamp) {
+    ATRACE_CALL();
     ALOGV("%s()", __func__);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
     ALOG_ASSERT(mEncoder);
@@ -740,6 +748,7 @@
 }
 
 void EncodeComponent::flush() {
+    ATRACE_CALL();
     ALOGV("%s()", __func__);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
 
@@ -771,6 +780,7 @@
 }
 
 void EncodeComponent::fetchOutputBlock(uint32_t size, std::unique_ptr<BitstreamBuffer>* buffer) {
+    ATRACE_CALL();
     ALOGV("Fetching linear block (size: %u)", size);
     std::shared_ptr<C2LinearBlock> block;
     c2_status_t status = mOutputBlockPool->fetchLinearBlock(
@@ -954,6 +964,7 @@
 }
 
 void EncodeComponent::reportWork(std::unique_ptr<C2Work> work) {
+    ATRACE_CALL();
     ALOG_ASSERT(work);
     ALOGV("%s(): Reporting work item as finished (index: %llu, timestamp: %llu)", __func__,
           work->input.ordinal.frameIndex.peekull(), work->input.ordinal.timestamp.peekull());