Google Git
Sign in
android / platform / frameworks / support / 7bee15777aa317a9f4b4f000bec514fda0b53dbc
commit7bee15777aa317a9f4b4f000bec514fda0b53dbc[log] [tgz]
authorTahsin Masrur <[email protected]>Fri Aug 23 13:09:47 2024 +0800
committerTahsin Masrur <[email protected]>Fri Aug 30 17:38:51 2024 +0800
treeb88b0501ff6fef493f0cc6dbb9e7c7550d1af97d
parent2dfc326798f11d8fcebf7fa7e7c9d69af0a2b69b [diff]
Refactor TorchControl to simplify and optimize the logic

  The primary objective in this CL is setting AE mode at the same capture request where torch mode is set. Currently, we set the torch mode first and await its submission before updating the AE mode in a separate request. This can be error-prone in future changes as well for cases like when user sets some AE mode in the middle of these two operations. Ideally, we should be able to do a single quick synchronous update to CameraPipe when user calls enableTorch or disableTorch.

1. Allow users to override the AE mode set at Controller3A#setTorch
- This allows us to set the appropriate AE mode at the same request of disabling torch. Otherwise, two separate requests need to be used.
2. Simplify TorchControl by awaiting on Controller3A.setTorch only instead of requiring to depend on update3A as well to workaround the previous limitation.

  This can be helpful in aosp/3210473 as well, see the difference in TorchControl vs other control classes there in patch 17.

Bug: 358093572
Test: TorchControlTest, CameraControlAdapterDeviceTest
Change-Id: I54098ff833f915976d3c445c6f53b489c6176f32
11 files changed
tree: b88b0501ff6fef493f0cc6dbb9e7c7550d1af97d
  1. .github/
  2. .idea/
  3. activity/
  4. annotation/
  5. appcompat/
  6. appintegration/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. binarycompatibilityvalidator/
  13. biometric/
  14. bluetooth/
  15. browser/
  16. buildSrc/
  17. buildSrc-tests/
  18. busytown/
  19. camera/
  20. car/
  21. cardview/
  22. collection/
  23. compose/
  24. concurrent/
  25. constraintlayout/
  26. contentpager/
  27. coordinatorlayout/
  28. core/
  29. credentials/
  30. cursoradapter/
  31. customview/
  32. datastore/
  33. development/
  34. docs/
  35. docs-public/
  36. docs-tip-of-tree/
  37. documentfile/
  38. draganddrop/
  39. drawerlayout/
  40. dynamicanimation/
  41. emoji/
  42. emoji2/
  43. enterprise/
  44. exifinterface/
  45. external/
  46. fragment/
  47. glance/
  48. gradle/
  49. graphics/
  50. gridlayout/
  51. health/
  52. heifwriter/
  53. hilt/
  54. ink/
  55. input/
  56. inspection/
  57. interpolator/
  58. javascriptengine/
  59. kruth/
  60. leanback/
  61. lifecycle/
  62. lint/
  63. lint-checks/
  64. loader/
  65. media/
  66. mediarouter/
  67. metrics/
  68. navigation/
  69. paging/
  70. palette/
  71. pdf/
  72. percentlayout/
  73. placeholder/
  74. placeholder-tests/
  75. playground-common/
  76. playground-projects/
  77. preference/
  78. print/
  79. privacysandbox/
  80. profileinstaller/
  81. recommendation/
  82. recyclerview/
  83. remotecallback/
  84. resourceinspection/
  85. room/
  86. safeparcel/
  87. samples/
  88. savedstate/
  89. security/
  90. sharetarget/
  91. slice/
  92. slidingpanelayout/
  93. sqlite/
  94. stableaidl/
  95. startup/
  96. swiperefreshlayout/
  97. test/
  98. testutils/
  99. tracing/
  100. transition/
  101. tv/
  102. tvprovider/
  103. vectordrawable/
  104. versionedparcelable/
  105. viewpager/
  106. viewpager2/
  107. wear/
  108. webkit/
  109. window/
  110. work/
  111. .gitignore
  112. build.gradle
  113. cleanBuild.sh
  114. code-review.md
  115. CONTRIBUTING.md
  116. gradle.properties
  117. gradlew
  118. libraryversions.toml
  119. LICENSE.txt
  120. OWNERS
  121. PREUPLOAD.cfg
  122. README.md
  123. settings.gradle
  124. studiow
  125. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Develocity

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.