| <?xml version="1.0" encoding="UTF-8"?> |
| <issues format="6" by="lint 9.0.0-dev" type="baseline" client="" dependencies="true" name="" variant="all" version="9.0.0-dev"> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val DEFAULT_PREVIEW_SIZE = JBUI.scale(50)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/explorer/AssetListView.kt" |
| line="31" |
| column="41"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private val scaledCellSize = JBUIScale.scale(cellSize)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/widget/ChessBoardPanel.kt" |
| line="65" |
| column="44"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int INTER_SECTION_SPACING = JBUIScale.scale(1);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="51" |
| column="55"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int HEADER_TO_BODY_SPACING = JBUIScale.scale(4);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="52" |
| column="56"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int TOP_PADDING = JBUIScale.scale(40);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="65" |
| column="45"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int NAME_OFFSET = JBUIScale.scale(50);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="66" |
| column="45"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int MIN_API_FONT_SIZE = JBUIScale.scale(18);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="67" |
| column="51"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int MAX_API_FONT_SIZE = JBUIScale.scale(45);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="68" |
| column="51"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int API_OFFSET = JBUIScale.scale(120);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="69" |
| column="44"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private final int NUMBER_OFFSET = JBUIScale.scale(10);" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/DistributionChartComponent.java" |
| line="70" |
| column="47"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val DEFAULT_IMAGE_SIZE = JBUI.scale(48)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcechooser/DrawableGrid.kt" |
| line="48" |
| column="39"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val FLOW_LAYOUT_GAP = JBUI.scale(4)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/qualifiers/QualifierConfigurationPanel.kt" |
| line="53" |
| column="36"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val MIN_FIELD_SIZE = JBUI.scale(40)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/explorer/ResourceExplorerToolbar.kt" |
| line="63" |
| column="35"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val PREF_FIELD_SIZE = JBUI.scale(125)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/explorer/ResourceExplorerToolbar.kt" |
| line="64" |
| column="36"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val MAX_FIELD_SIZE = JBUI.scale(150)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/explorer/ResourceExplorerToolbar.kt" |
| line="65" |
| column="35"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val GAP_SIZE = JBUI.scale(10)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/explorer/ResourceExplorerToolbar.kt" |
| line="67" |
| column="29"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private val listsGap = JBUI.scale(16)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/widget/SectionList.kt" |
| line="70" |
| column="31"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1=" private val lineWidth = JBUI.scale(1)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/widget/Separator.kt" |
| line="34" |
| column="32"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val ASSET_FIXED_WIDTH = JBUI.scale(150)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/sketchImporter/ui/SketchImporterView.kt" |
| line="51" |
| column="38"/> |
| </issue> |
| |
| <issue |
| id="JbUiStored" |
| message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes" |
| errorLine1="private val ASSET_FIXED_HEIGHT = JBUI.scale(150)" |
| errorLine2=" ~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/sketchImporter/ui/SketchImporterView.kt" |
| line="52" |
| column="39"/> |
| </issue> |
| |
| <issue |
| id="VisibleForTests" |
| message="This method should only be accessed from tests or within private scope" |
| errorLine1=" AnalyticsSettings.setInstanceForTest(analyticsSettings);" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/startup/AndroidStudioAnalyticsImpl.java" |
| line="55" |
| column="27"/> |
| </issue> |
| |
| <issue |
| id="VisibleForTests" |
| message="This method should only be accessed from tests or within private scope" |
| errorLine1=" androidTestSources?.containsFile(virtualFile) == false && !androidTestSources.isContainedBy(virtualFile) &&" |
| errorLine2=" ~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/testartifacts/instrumented/AndroidTestConfigurationProducer.kt" |
| line="197" |
| column="85"/> |
| </issue> |
| |
| <issue |
| id="VisibleForTests" |
| message="This method should only be accessed from tests or within private scope" |
| errorLine1=" generatedAndroidTestSources?.containsFile(virtualFile) == false && !generatedAndroidTestSources.isContainedBy(virtualFile)" |
| errorLine2=" ~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/testartifacts/instrumented/AndroidTestConfigurationProducer.kt" |
| line="198" |
| column="103"/> |
| </issue> |
| |
| <issue |
| id="VisibleForTests" |
| message="This method should only be accessed from tests or within package private scope" |
| errorLine1=" if (captureDiagnostics) ModuleClassLoadedDiagnosticsImpl()" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/org/jetbrains/android/uipreview/StudioModuleClassLoaderManager.kt" |
| line="425" |
| column="31"/> |
| </issue> |
| |
| <issue |
| id="FileComparisons" |
| message="Do not compare java.io.File with `equals` or `==`: will not work correctly on case insensitive file systems! See `go/files-howto`." |
| errorLine1=" if (file == mainManifestFile) {" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/model/MergedManifestInfo.java" |
| line="423" |
| column="9"/> |
| </issue> |
| |
| <issue |
| id="CommonForkJoinPool" |
| message="Avoid using common ForkJoinPool, directly or indirectly (for example via CompletableFuture). It has a limited set of threads on some machines which leads to hangs. See `go/do-not-freeze`." |
| errorLine1=" ForkJoinPool.commonPool().execute(() -> {" |
| errorLine2=" ~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/fonts/MoreFontsDialog.java" |
| line="576" |
| column="22"/> |
| </issue> |
| |
| <issue |
| id="ImplicitExecutor" |
| message="Use `runAsync` overload with an explicit Executor instead. See `go/do-not-freeze`." |
| errorLine1=" CompletableFuture.runAsync { Files.deleteIfExists(report.hprofPath) }" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/diagnostics/hprof/action/AnalysisRunnable.kt" |
| line="103" |
| column="7"/> |
| </issue> |
| |
| <issue |
| id="ImplicitExecutor" |
| message="Use `supplyAsync` overload with an explicit Executor instead. See `go/do-not-freeze`." |
| errorLine1=" return CompletableFuture.supplyAsync(this::getLicenseTextSync);" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/actions/license/LicenseTextCollector.java" |
| line="38" |
| column="12"/> |
| </issue> |
| |
| <issue |
| id="ImplicitExecutor" |
| message="Use `supplyAsync` overload with an explicit Executor instead. See `go/do-not-freeze`." |
| errorLine1=" CompletableFuture.supplyAsync {" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/plugin/RasterAssetRenderer.kt" |
| line="36" |
| column="5"/> |
| </issue> |
| |
| <issue |
| id="ImplicitExecutor" |
| message="Use `supplyAsync` overload with an explicit Executor instead. See `go/do-not-freeze`." |
| errorLine1=" return CompletableFuture.supplyAsync {" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/ui/resourcemanager/plugin/SVGAssetRenderer.kt" |
| line="37" |
| column="12"/> |
| </issue> |
| |
| <issue |
| id="WrongThread" |
| message="Call must be from `@{Slow,WorkerThread}`, but context is allowing `@UiThread`" |
| errorLine1=" SourceFilePosition location = ManifestUtils.getActionLocation(myFacet.getModule(), record);" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/editors/manifest/ManifestPanel.java" |
| line="541" |
| column="51"/> |
| </issue> |
| |
| <issue |
| id="WrongThread" |
| message="Call must be from `@{Slow,WorkerThread}`, but context is allowing `@UiThread`" |
| errorLine1=" file = createMetadataForFile(myFacet, ManifestUtils.getActionLocation(myFacet.getModule(), record)).getFile();" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/editors/manifest/ManifestPanel.java" |
| line="670" |
| column="61"/> |
| </issue> |
| |
| <issue |
| id="WrongThread" |
| message="Call must be from `@{Slow,WorkerThread}`, but context is allowing `@UiThread`" |
| errorLine1=" if (FileUtil.filesEqual(ManifestUtils.getActionLocation(myFacet.getModule(), record).getFile().getSourceFile(), mainManifest)) {" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/editors/manifest/ManifestPanel.java" |
| line="744" |
| column="45"/> |
| </issue> |
| |
| <issue |
| id="WrongThread" |
| message="Call must be from `@{Slow,WorkerThread}`, but context is allowing `@UiThread`" |
| errorLine1=" SourceFilePosition sourceFilePosition = ManifestUtils.getActionLocation(myFacet.getModule(), record);" |
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> |
| <location |
| file="src/com/android/tools/idea/editors/manifest/ManifestPanel.java" |
| line="754" |
| column="61"/> |
| </issue> |
| |
| </issues> |
